Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix instance snackbar #1211

Closed

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Mar 20, 2024

Pull Request Description

This PR fixes a strange issue where the snackbar indicating an error navigating to an instance would not appear unless the user interacted with the UI in some other way. I believe this is related to the fact that we're using addPostFrameCallback, but there's no other building operation happening. (Most if not all other snackbars are usually related to something that changes/builds at the same time). There may be a better way to fix this, and I'm open to ideas, but for now I just added a condition for whether to use the post-frame or not.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Before

qemu-system-x86_64_yu2BDIbWoV.mp4

After

qemu-system-x86_64_h9IYsXv8uY.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@micahmo
Copy link
Member Author

micahmo commented Mar 21, 2024

Note that this might not be an issue now with #1218, but it might not hurt to have this option in the snackbar anyway.

@hjiangsu
Copy link
Member

I think we can leave this out if its no longer needed! If we end up needing it in the future, we'll merge it in - just helps with keeping the codebase a bit cleaner 😅

@micahmo
Copy link
Member Author

micahmo commented Mar 23, 2024

Sounds good, I'll close this PR but keep my branch just in case.

@micahmo micahmo closed this Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants