-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add development flavor #1214
Add development flavor #1214
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooh, this looks like a great idea!
By any chance is there a way to show the flavor name in the home screen?
I was trying this out, but it looks weird on iOS because theres a 12 character limit before iOS removes spaces. So |
I like that idea! |
Oh I think that looks awesome!! It's not too small at all. |
I'll go ahead and merge this in, and we can add more tweaks to the design later if we want to! |
The build command I usually use for my phone is flutter build apk --profile --no-tree-shake-icons It seems to still work, but now spits out
Is this because the naming of the .apk changed? Should I change my command? |
Ahh you have to add |
Thanks, that worked! |
Pull Request Description
This PR adds flavors to Thunder (mostly dev-facing feature for now). When we run a debug build of Thunder on a physical device, the debug build stops working when we disconnect the debugger. Therefore, to use Thunder outside of development, I have to run a profile/release build after I finish all dev-related tasks. This was a bit of a hassle so I decided to implement flavors.
For now, this PR adds two flavors: production and development.
production
flavor is the general release/nightly builds of Thunder (e.g., profile/release builds)development
flavor is for any in-development feature builds of Thunder (e.g., debug builds). The only difference is the color of the icon to help differentiate it a bit. Future enhancements to this would be to add a separate splash screen to indicate the flavor.nightly
flavor for nightly builds.The benefit of this is that we can now compare between two different versions of Thunder by running different versions on different flavors.
Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
Checklist
semanticLabel
s where applicable for accessibility?