Fix sidebar overflow #1248
Merged
Fix sidebar overflow #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjiangsu
approved these changes
Mar 30, 2024
| fontWeight: FontWeight.bold, | ||
| fontSize: 16, | ||
| SizedBox( | ||
| width: MediaQuery.of(context).size.width * 0.55, |
There was a problem hiding this comment.
Just curious, but where does the 0.55 come from?
There was a problem hiding this comment.
I just tweaked the percentage until it looked good. I figured since it was a percentage rather than a fixed value it should scale to other devices. What do you think?
I tried FractionallySizedBox first, since that's what the whole sidebar uses, but it didn't work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This is a small PR which addresses some sidebar overflow I noticed.
Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
Checklist
semanticLabels where applicable for accessibility?