Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR fixes an issue with taglines. Currently there is some logic to condense the tagline if it's very long. However, this logic performs a very simple string truncation, which can break the tagline if it truncates in the middle of markdown.
I fixed this issue by using a similar technique to the post body expander, so that the it is done by height, rather than characters. I also introduced a measurement, so the truncation only happens if the tagline is taller than a specified height. We might consider introducing this mechanism back into the post body (because I've seen cases where the body is short and the expander does almost nothing).
Issue Being Fixed
Before
tagline_before.mp4
After
tagline_after.mp4
After -- short tagline still has no expander
Issue Number: N/A
Screenshots / Recordings
Checklist
semanticLabel
s where applicable for accessibility?