Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly improve mentions #1271

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Apr 3, 2024

Pull Request Description

This PR slightly improves mentions. There's probably more work that needs to go in there to make them more like replies (maybe just using CommentReference), but at least now the originating username follows standards from through the app.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Before After
image image

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@hjiangsu hjiangsu merged commit e0633ca into thunder-app:develop Apr 29, 2024
1 check passed
@micahmo micahmo deleted the feature/improve-mentions branch April 29, 2024 17:23
@CTalvio
Copy link
Collaborator

CTalvio commented May 3, 2024

This PR slightly improves mentions. There's probably more work that needs to go in there to make them more like replies (maybe just using CommentReference), but at least now the originating username follows standards from through the app.

Lemmy doesn't actually work with post body mentions, we could absolutely go ahead and just make mentions use the exact widgets that replies do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants