Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor post page quick actions #1279

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Conversation

hjiangsu
Copy link
Member

@hjiangsu hjiangsu commented Apr 5, 2024

Pull Request Description

This PR refactors the post page quick actions bar into its own widget PostQuickActionsBar. This is mainly to simplify the PostSubview widget and will pave the way for the post page refactor!

This will also make #1197 a bit easier to implement!

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense and LGTM!

Would this also be a good opportunity to fix the padding so that the divider above the quick actions can be full width? I think that will require removing the overall padding and then adding it back to the individual elements except the divider.

@hjiangsu
Copy link
Member Author

hjiangsu commented Apr 6, 2024

Would this also be a good opportunity to fix the padding so that the divider above the quick actions can be full width?

This can be done at a later step! I'm slowly working on refactoring parts of the post view in chunks (see #1281 for more refactoring logic)

@hjiangsu hjiangsu merged commit 98b0a20 into develop Apr 10, 2024
1 check passed
@hjiangsu hjiangsu deleted the refactor/post-quick-actions branch April 10, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants