Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subscribe/favorite issue #1288

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Apr 8, 2024

Pull Request Description

This PR fixes an issue where subscribing to a community and favoriting it from the appbar didn't always work.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Before

subscribe-issue-.before.mp4

After

subscribe-issue-after.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@machinaeZER0
Copy link
Collaborator

Thank yooooooou - meant to see if an issue for this was filed the other day, great catch!

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit 217263d into thunder-app:develop Apr 10, 2024
1 check passed
@micahmo micahmo deleted the fix/subscribe-favorite-issue branch April 10, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants