Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new sort types as defaults #1298

Merged

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Apr 11, 2024

Pull Request Description

The PR adds "Scaled" and "Controversial" to the possible default feed sorting options, and "Controversial" to the possible comment sorting options. If connected to an instance that doesn't support these types, Thunder's built-in defaults will be applied (Hot and Top, respectively). Along with these changes I added several new helpers to the LemmyClient class, such as a getter for the current version, and the ability to compare an arbitrary version against a feature. This turned out to be a bigger effort than I was expecting, so I think now (early in the release cycle) is a great time to get it in and tested!

Issue Being Fixed

Issue Number: #1002

Screenshots / Recordings

new-sort-demo.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This should hopefully make version-restricted features easier to implement!

@hjiangsu hjiangsu merged commit 28a4153 into thunder-app:develop Apr 12, 2024
1 check passed
@micahmo micahmo deleted the feature/new-sort-types-default branch April 14, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants