Add support for new sort types as defaults #1298
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
The PR adds "Scaled" and "Controversial" to the possible default feed sorting options, and "Controversial" to the possible comment sorting options. If connected to an instance that doesn't support these types, Thunder's built-in defaults will be applied (Hot and Top, respectively). Along with these changes I added several new helpers to the
LemmyClient
class, such as a getter for the current version, and the ability to compare an arbitrary version against a feature. This turned out to be a bigger effort than I was expecting, so I think now (early in the release cycle) is a great time to get it in and tested!Issue Being Fixed
Issue Number: #1002
Screenshots / Recordings
new-sort-demo.mp4
Checklist
semanticLabel
s where applicable for accessibility?