Fix showing deleted comments #1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggichure
approved these changes
Apr 15, 2024
It looks like we can delete it - I'm assuming this was left over from the comment refactor a while back! Nice catch 😄 |
|
Ok deleted! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR fixes an issue where the contents of deleted comments can appear in some places (i.e., user profile). The cleaning code has been applied directly to the
CommentContentwidget so it automatically gets applied everywhere (rather than having to remember to do it in every different type of bloc).Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
Before
comment-before.mp4
After
comment-after.mp4
Checklist
semanticLabels where applicable for accessibility?