Optimistically mark replies as read #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggichure
approved these changes
Apr 23, 2024
hjiangsu
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR adds optimistic updates for marking replies as read. It also adds the ability to mark as unread.
In case there is an error, a snackbar will be displayed which lets the user refresh the inbox to see the current state of things. (I thought that would be preferable over forcible re-showing a reply that may have been previously hidden, for example.)
Issue Being Fixed
Issue Number: #863
Screenshots / Recordings
mark-read-optimistically.mp4
Error case
mark-read-error.mp4
Checklist
semanticLabels where applicable for accessibility?