Fix empty notifications #1324
Merged
Fix empty notifications #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I decided to tack on another fix for duplicate channels in OS settings by assigning the same channel ID for the same channel name. Note that this does not affect message grouping since it is done by group key instead. |
|
I added one more tiny fix related to the payload of the message where we were adding the wrong ID (of the comment instead of the reply). Now I'm working on the account issue, but that will be separate. |
ggichure
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR fixes an issue with getting empty notifications generated by background checks. If it makes you better, I believe this was a regression that I introduced and was not related to the notifications refactor! 😊 I also snuck in another fix for generating usernames.