Fix pan/pinch triggering unintentional doubletapzoom #1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # lib/shared/image_viewer.dart
micahmo
approved these changes
Apr 29, 2024
|
Yup, just a few lines of code but good to have in a nightly first and check if it needs any tuning. I did load this one up on my actual phone to give it a go a seems a huge improvement. Double tap zoom is nicer to use, too. |
hjiangsu
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This adds a movement check to onPointerUp in order to prevent triggering double tap slide zoom unintentionally.
Issue Being Fixed
Issue Number: #1164
Checklist