Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New single-side score indicator icon using stacked arrows #1341

Merged
merged 2 commits into from
May 14, 2024

Conversation

CTalvio
Copy link
Collaborator

@CTalvio CTalvio commented May 2, 2024

Pull Request Description

The combined score metadata indicator used two icons on either side of the score.

Issue Being Fixed

The two icons require additional space and break the Icon:Data:Icon:Data pattern.

Screenshots / Recordings

Screenshot_20240502_132300

Checklist

  • Did you update CHANGELOG.md?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to solicit more feedback from the community, but I think this looks pretty slick to me!

@CTalvio
Copy link
Collaborator Author

CTalvio commented May 2, 2024

It'll also apply to the cross-post metadata. It's a matter of taste how exactly you arrange the two arrows, but any way is an improvement over having one icon on either side IMO, at least in terms of space.

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit ab41128 into thunder-app:develop May 14, 2024
1 check passed
@CTalvio CTalvio deleted the combined_vote_icon branch May 14, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants