Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve gesture setting clarity with icons #1345

Merged
merged 3 commits into from
May 8, 2024
Merged

Improve gesture setting clarity with icons #1345

merged 3 commits into from
May 8, 2024

Conversation

CTalvio
Copy link
Collaborator

@CTalvio CTalvio commented May 2, 2024

Pull Request Description

This adds some arrows to indicate which gesture entry is the long and short pull.

Issue Being Fixed

I keep mixing these up.

image

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

hjiangsu
hjiangsu approved these changes May 5, 2024
View reviewed changes
Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just a couple of minor comments.

@hjiangsu hjiangsu merged commit f36b0a6 into thunder-app:develop May 8, 2024
1 check passed
@CTalvio CTalvio deleted the gesture_setting_clarity branch May 8, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjiangsu hjiangsu hjiangsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CTalvio @hjiangsu