Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix superscript/subscript parsing #1395

Merged
merged 1 commit into from
May 30, 2024
Merged

Fix superscript/subscript parsing #1395

merged 1 commit into from
May 30, 2024

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented May 29, 2024

Pull Request Description

This is a small PR which fixes a markdown parsing issue I noticed where superscript/subscript would be rendered inside of inline code block (when they shouldn't be).

As a nice side-effect, I believe this also fixes the problem that had been commented in code as not supported.
This is a text^superscript^ and this is a text~subscript~

I also re-tested with this comment, and everything still looks good!

Demo

Found in https://programming.dev/comment/9864839

Before After
image image

hjiangsu
hjiangsu approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu added this to the 0.5.0 milestone May 30, 2024
@hjiangsu hjiangsu merged commit fb91938 into thunder-app:develop May 30, 2024
1 check passed
@micahmo micahmo deleted the fix/markdown-parsing branch May 30, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjiangsu hjiangsu hjiangsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@micahmo @hjiangsu