Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A few client-side notifications improvements #1400

Merged
merged 2 commits into from
Jun 8, 2024
Merged

A few client-side notifications improvements #1400

merged 2 commits into from
Jun 8, 2024

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented May 30, 2024

Pull Request Description

This PR fixes a couple of minor client-side issues related to notifications.

  • Fixed an issue where the group notification was not generated for inbox notifications from UnifiedPush
  • Improve the account lookup for UnifiedPush notifications so that it can't be confused by identical usernames on different instances
  • Remove images from contents (which aren't formatted properly) and replace with placeholder text

hjiangsu
hjiangsu approved these changes Jun 8, 2024
View reviewed changes
Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hjiangsu hjiangsu merged commit 7502997 into thunder-app:develop Jun 8, 2024
1 check passed
@micahmo micahmo deleted the fix/notifications-client-stuff branch June 9, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjiangsu hjiangsu hjiangsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@micahmo @hjiangsu