Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to view entire post as a different account #1409

Merged

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Jun 1, 2024

Pull Request Description

This PR adds the ability to view a post as a different account. This allows you to perform all post-related actions, like voting/saving/etc. As soon as you navigate back, your original account will be restored. If the post is not found on the instance you switch to, a warning will be shown and the account will be reverted.

Hide whitespace.

Note to self: newly created comments aren't getting added automatically. I think this should be allowed, if the create comment page's user matches the post page's user, so it's just something to look into, but not a big deal.

Issue Being Fixed

Issue Number: #341

Screenshots / Recordings

Apologies for the delay in the recording where I'm waiting for federation. 😊

qemu-system-x86_64_nS8AfircR6.mp4

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have to say, this is super cool (and equally surprised that it seems like there weren't too many changes required to implement this)!

Looked through the code and it LGTM. Have not tested it physically but we can merge it in first!

@hjiangsu hjiangsu merged commit 8c8ce53 into thunder-app:develop Jun 5, 2024
1 check passed
@micahmo
Copy link
Member Author

micahmo commented Jun 5, 2024

surprised that it seems like there weren't too many changes required to implement this

Yeah, the temporary account switching framework has come in very handy and makes these kinds of features pretty easy to implement now, and that combined with how the new Post Page reacts to the bloc event, which can emit the entire post object, made this pretty straightforward. 😊

Let me know if you can think of any other places where it would make sense to implement a feature like this!

@micahmo micahmo deleted the feature/view-post-as-different-account branch June 5, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants