Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for user labels #1434

Merged
merged 8 commits into from
Jun 10, 2024
Merged

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Jun 6, 2024

Pull Request Description

This PR adds support for adding customized tags/labels for other users that you encounter. This is a popular feature of many Reddit and now Lemmy apps, and it lets you make a note of anything significant that you want to remember about a particular user.

Note: This should probably not be added until #1432 so people have a way to save their labels!

Hide whitespace.

qemu-system-x86_64_pkzuoaTFcs.mp4
qemu-system-x86_64_0SeOHz0drF.mp4

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super cool, thanks for implementing it! Just have some minor nitpicks but otherwise LGTM!

(I'll wait until #1432 as you mentioned 😄)

lib/shared/dialogs.dart Outdated Show resolved Hide resolved
lib/account/models/user_label.dart Show resolved Hide resolved
lib/account/models/user_label.dart Show resolved Hide resolved
@hjiangsu hjiangsu added this to the 0.5.0 milestone Jun 9, 2024
@micahmo
Copy link
Member Author

micahmo commented Jun 9, 2024

P.S. I added a downgrade strategy so users call roll back to a previous version without breaking the database.

@hjiangsu hjiangsu merged commit 596e36c into thunder-app:develop Jun 10, 2024
1 check passed
@micahmo micahmo deleted the feature/user-labels branch June 10, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants