Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show sort on header #1476

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Jul 8, 2024

Pull Request Description

This PR adds the sort type to the community and user headers. I noticed that there was no way to immediately see the sort type without either changing it or scrolling up so that it appears in the app bar.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Note that on most phone screens with a better resolution, the sort type will not wrap down and will instead be in alignment with the other statistics.

image

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit 4c089eb into thunder-app:develop Jul 8, 2024
1 check passed
@micahmo micahmo deleted the feature/sort-on-header branch July 8, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants