Re-introduce comment navigator for new post page #1496
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR adds back the comment navigator for the new experimental post page. The general logic remains similar to the current implementation, but with one behavioural change. Because the comments are now flattened, the comment navigator will navigate to each child comment (as opposed to the next parent comment). A separate PR will be made to allow navigation between top-level comments using this navigation.
With this, I've also added back the ability to scroll to the last comment (somewhat). There are some quirks here due to the transition to slivers. Slivers don't have a RenderBox associated with them, so fetching the height of the sliver is less trivial (from my testing). I do think I have it at a good point, but will need to do more testing on it to be sure.
More specifically, this PR fixes the following:
Issue Being Fixed
Issue Number: #1413
Screenshots / Recordings
Checklist
semanticLabel
s where applicable for accessibility?