Fix partial percent encoded links in markdown images #1572
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This is a small PR which fixes an issue mentioned in the following post: https://lemmy.world/post/20288898. The reason why the image was failing to load properly was due to a partially encoded string.
Note: the markdown/image library that we use already handles encoding for URLs - this is a special case where the URL was only partially encoded.
The problematic string that was passed down to the markdown widget was
https://upload.wikimedia.org/wikipedia/commons/4/44/Trať_u_osady_Luh_%28u_Bezpráví%29_1.jpg
%28
and%29
correspond to(
and)
respectively. However, all other non-ASCII characters were not percent-encodedThe fix here is to perform full decoding on the URL before passing it to our image library. The image library should automatically handle encoding!
Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
Checklist
semanticLabel
s where applicable for accessibility?