Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use image dimensions from API (v0.19.6) #1594

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

hjiangsu
Copy link
Member

@hjiangsu hjiangsu commented Nov 17, 2024

Pull Request Description

This PR adds the ability for Thunder to use the image dimensions provided from the Lemmy API (for instances using v0.19.6 and above). This should help improve overall app performance for those using instances v0.19.6 and above since it allows us to bypass retrieveImageDimensions function to pre-load images to fetch their dimensions.

As a result, this will also potentially help reduce layout jank on the feed page since more posts will be able to properly fetch the dimensions.

I have also added in the error message for the snackbar that pops up after creating a new post. This should help narrow down the issue found in the Matrix room.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this should be a big improvement!

@hjiangsu hjiangsu merged commit 1b33f7d into develop Nov 18, 2024
1 check passed
@hjiangsu hjiangsu deleted the feature/image-dimension branch November 18, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants