Use image dimensions from API (v0.19.6) #1594
Merged
+25
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR adds the ability for Thunder to use the image dimensions provided from the Lemmy API (for instances using v0.19.6 and above). This should help improve overall app performance for those using instances v0.19.6 and above since it allows us to bypass
retrieveImageDimensions
function to pre-load images to fetch their dimensions.As a result, this will also potentially help reduce layout jank on the feed page since more posts will be able to properly fetch the dimensions.
I have also added in the error message for the snackbar that pops up after creating a new post. This should help narrow down the issue found in the Matrix room.
Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
Checklist
semanticLabel
s where applicable for accessibility?