Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR fixes the appearance of
TextField
s which seemingly shrunk in height after the upgrades. It turns out that the ones with this problem were marked asisDense
. To be honest, it might have been a bug before that they were marked as dense but didn't look any different, and maybe now after the upgrade the dense flag is being respected more. However, unless we like the change, removing the flag allows us to restore the previous appearance.Note: I left
isDense
in the CreatePostPage because we have intentionally shrunk those fields in order to make better use of the screen real estate (see #1498). For whatever reason, this usage ofisDense
looked the same before as it does now.Also I believe this is the last of the color/style issues since the big upgrades, so it will be nice to be able to move on from this and get back to working on features. :-) It also makes me feel a lot better about doing a new release soon.
Issue Being Fixed
Issue Number: #1565 (comment)
Screenshots / Recordings
login.page.mp4
user.label.mp4
Checklist
semanticLabel
s where applicable for accessibility?