Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TextField height #1622

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Dec 5, 2024

Pull Request Description

This PR fixes the appearance of TextFields which seemingly shrunk in height after the upgrades. It turns out that the ones with this problem were marked as isDense. To be honest, it might have been a bug before that they were marked as dense but didn't look any different, and maybe now after the upgrade the dense flag is being respected more. However, unless we like the change, removing the flag allows us to restore the previous appearance.

Note: I left isDense in the CreatePostPage because we have intentionally shrunk those fields in order to make better use of the screen real estate (see #1498). For whatever reason, this usage of isDense looked the same before as it does now.

Also I believe this is the last of the color/style issues since the big upgrades, so it will be nice to be able to move on from this and get back to working on features. :-) It also makes me feel a lot better about doing a new release soon.

Issue Being Fixed

Issue Number: #1565 (comment)

Screenshots / Recordings

login.page.mp4
user.label.mp4

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks again for looking into the colour/styling issues! ☺️

@hjiangsu hjiangsu merged commit a75bc03 into thunder-app:develop Dec 6, 2024
1 check passed
@micahmo micahmo deleted the fix/textfield-height branch December 6, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants