Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not re-load inbox when already selected #1624

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Dec 6, 2024

Pull Request Description

This PR fixes a pretty small issue where tapping on the inbox page when it was already selected would cause it to reload again (and for some reason it would clear out the contents of the inbox). Rather than trying to figure out why that happens, I decided to make it so that tapping on the inbox when it's already selected does nothing. I think that makes more sense anyway!

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Before

qemu-system-x86_64_DvHqz0u2IO.mp4

After

qemu-system-x86_64_JglY9KwsIN.mp4

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit eb6f495 into thunder-app:develop Dec 6, 2024
1 check passed
@micahmo micahmo deleted the fix/reload-inbox branch December 6, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants