Migrate from uni_links to app_links for deep links #1626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjiangsu
commented
Dec 6, 2024
| @@ -26,12 +26,12 @@ | |||
| android:theme="@style/LaunchTheme" | |||
| android:configChanges="orientation|keyboardHidden|keyboard|screenSize|smallestScreenSize|locale|layoutDirection|fontScale|screenLayout|density|uiMode" | |||
| android:hardwareAccelerated="true" | |||
| android:resizeableActivity="true"> | |||
| android:resizeableActivity="true" | |||
There was a problem hiding this comment.
I think I may have also inadvertently found the issue that was causing #1575! I'm not entirely sure if this is the case, but there was an extra > which might've caused android:windowSoftInputMode="adjustResize" to not be respected.
For reference: https://developer.android.com/develop/ui/views/touch-and-input/keyboard-input/visibility#Respond
micahmo
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR migrates our existing usage of
uni_linksover toapp_links. The main reason for this being thatuni_linkshas been discontinued, and has been replaced byapp_linksinstead. See https://pub.dev/packages/uni_links for more details.@micahmo I know you just tested deep links, but it would be helpful if you could re-test them with this migration! I did a quick test on an Android emulator and it seems to be working, so I'm hoping it works seamlessly on a physical device (especially in profile/release modes as I needed to add some proguard rules according to their setup).
Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
Checklist
semanticLabels where applicable for accessibility?