Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back custom action inkwell colors for post bottom sheet #1627

Merged

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Dec 9, 2024

Pull Request Description

This PR fixes a "breaking change" (I put that in quotes because it's really just cosmetic 😊) introduced by the post bottom sheet refactor in #1567, which is that we lost the colored inkwells for the quick actions. This is such a minor thing, but it was introduced by @CTalvio back in the day and I really like it, so I wanted to bring it back. Note that this still works fine in the post page itself, as well as the bottom sheet for comments.

P.S. @hjiangsu are you planning on a doing a similar refactor for comments any time soon? Right now the bottom sheets look and act differently which causes a slightly disjointed user experience.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

qemu-system-x86_64_nIzKDB1iMs.mp4

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@hjiangsu
Copy link
Member

P.S. @hjiangsu are you planning on a doing a similar refactor for comments any time soon? Right now the bottom sheets look and act differently which causes a slightly disjointed user experience.

Definitely, this is on my to-do list before the general release of v0.6.0 (in addition to some more comment moderation tools if I can get around to them)!

The changes look good - I was planning on releasing v0.6.0-2 nightly in a bit, so I'll hold off on merging this in until then!

@hjiangsu hjiangsu merged commit 1865089 into thunder-app:develop Dec 12, 2024
1 check passed
@micahmo micahmo deleted the feature/post-bottom-sheet-colors branch December 12, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants