Improve UX for toggling pure black theme #1690
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR applies the feedback from #1605 (comment) to improve the UX for enabling and disabling pure black theme. Here's the new flow:
I've also added some migration steps for those who are currently using the pure black theme directly! I've tested most if not all possible variations, and also tested the migration steps.
Note: I've kept
setting_theme_system_pure_black
andsystemThemePureBlack
the same to prevent issues with users who were previously using that setting. I have however, renamed the variables to match the new context.Issue Being Fixed
Issue Number: #1598
Screenshots / Recordings
Checklist
semanticLabel
s where applicable for accessibility?