Data getter #98
Merged
Data getter #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm, no sooner do I create the PR than I realize what I'm missing - need to add support for a mixture of slices and individual indices in getRange (and the brackets accessor). Coming right up... also apparently I need to resolve a merge conflict... |
Conflicts: python/test/test_series.py
| return True | ||
|
|
||
| if not hasattr(sliceOrSlices, '__len__'): | ||
| # make my func the... |
There was a problem hiding this comment.
Don't understand this note =)
|
@industrial-sloth this is really nice! It's looking great, some minor comments, main one is about possibly reorganizing the tests. |
| else: | ||
| return filteredVals | ||
|
|
||
| def getAll(self, keys): |
There was a problem hiding this comment.
Rename to getMany to avoid confusion with collect
Apparently there are those in the world who do not immediately recognize a George Clinton / Parliament reference.
Check that requested key is of appropriate arity for RDD keys, based on a call to rdd.first() to get example key.
Previously threw exceptions. This differs from python dict or sequence behavior but is now consistent with get and getRange.
|
Ok, have updated this PR based on offline conversations with @freeman-lab.
|
|
Thanks @industrial-sloth ! LGTM, merging it in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for
getting individual records or sets of records fromDatasubtypes.Three methods are added, together with
__getitem__(brackets notation) as a syntactic convenience. The methods are:get: Returns a single record value, specified by record key (example:series.get((12,24,36)), returns series value at (12, 24, 36))getAll: Returns multiple record values, one for each key passed (example:images.getAll([2, 4, 6])returns a sequence of image arrays from time points 2, 4, and 6.getRange: returns multiple record values specified by slices (example:series.getRange([slice(1), slice(2,3)]returns the single series value with key (0, 2).getor togetRangedepending on whether a single key or a range of keys are passed (example:series[:3,2:3]returns values of keys (0,2), (1,2), (2,2)).