Add slow api rate limiting #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmount
reviewed
Jul 19, 2024
Comment on lines
+74
to
+93
| # Ensure the response was rate limited | ||
| assert response.status_code == 429, response.json() | ||
| data = response.json() | ||
| assert data['detail']['id'] == APIRateLimitExceeded.id_code |
There was a problem hiding this comment.
Why does the @limiter.limit("2/minute") for this not work here? It returns 200 in tests instead of expected 429?
There was a problem hiding this comment.
that's not right. I'll look into this next week.
|
This is due to the rate limiter's cache not being cleared between requests. But this also brings up another issue so this PR is on hold. |
* waiting-list/join - 2/minute * schedule/public/availability - 10/minute * schedule/public/availability/request - 10/minute
MelissaAutumn
force-pushed
the
features/466-rate-limit
branch
from
c0d3c43
to
ac32f81
Compare
MelissaAutumn
temporarily deployed
to
staging
GitHub Actions
Inactive
MelissaAutumn
temporarily deployed
to
staging
GitHub Actions
Inactive
MelissaAutumn
had a problem deploying
to
staging
GitHub Actions
Failure
MelissaAutumn
temporarily deployed
to
staging
GitHub Actions
Inactive
MelissaAutumn
had a problem deploying
to
staging
GitHub Actions
Failure
MelissaAutumn
temporarily deployed
to
staging
GitHub Actions
Inactive
MelissaAutumn
temporarily deployed
to
staging
GitHub Actions
Inactive
MelissaAutumn
temporarily deployed
to
staging
GitHub Actions
Inactive
MelissaAutumn
temporarily deployed
to
staging
GitHub Actions
Inactive
MelissaAutumn
temporarily deployed
to
staging
GitHub Actions
Inactive
MelissaAutumn
temporarily deployed
to
staging
GitHub Actions
Inactive
MelissaAutumn
temporarily deployed
to
staging
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #466
Rules:
I think we could reduce the request one to like 2 or 3, but it's not really a concern right now. Mostly just preemptively avoiding spam. I didn't hook it up with redis because I don't think we have redis setup correctly on prod yet. Shouldn't be a problem for us right now though.
It works off of remote ip address, I think that's probably okay.