Qalendar fixes #587
Qalendar fixes #587
Conversation
There was a problem hiding this comment.
@MelissaAutumn I found the cause for the squished / streched calendar week / day views, but still no solution, since it's kind of a Qalendar issue imo.
| dayBoundaries: dayBoundary, | ||
| dayBoundaries: { | ||
| start: dayBoundary.value.start, | ||
| end: dayBoundary.value.end | ||
| }, |
There was a problem hiding this comment.
At the point of initializing this config object, dayBoundary.value holds the default values 0, 24 making Qalendar span the container element over that range. Updating the boundary later in the watcher causes Qalendar to recalculate the displayed time rows, but it doesn't update the row height.
| // TODO: This does update the boundary values, but does NOT update the container height! | ||
| qalendarRef.value.time.DAY_START = dayBoundary.value.start * 100; | ||
| qalendarRef.value.time.DAY_END = dayBoundary.value.end * 100; |
There was a problem hiding this comment.
Any ideas how to trigger a UI rerender of Qalendar at this point?
There was a problem hiding this comment.
We might need to adjust our fork, and then pull in our fork. But I'm not sure 🤔
| @@ -361,7 +363,6 @@ watch(route, () => { | |||
| </script> | |||
| <template> | |||
| <div | |||
| class="w-full" | |||
There was a problem hiding this comment.
This was also set on the parent. Removing the duplicated class here.
MelissaAutumn
force-pushed
the
bugs/544-qalendar-fixes
branch
from
e962266
to
aa78cd9
Compare
MelissaAutumn
temporarily deployed
to
staging
GitHub Actions
Inactive
MelissaAutumn
temporarily deployed
to
staging
GitHub Actions
Inactive
Description of the Change
Benefits
Consistent height of events after a change of the day boundary.
Applicable Issues
#544