Login Re-work Pt2 #646
Merged
Login Re-work Pt2 #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MelissaAutumn
commented
Sep 10, 2024
| <p style="font-weight: 700; margin: 0;"> | ||
| {{ l10n('confirm-email-mail-html-heading') }} | ||
| </p> | ||
| </div> | ||
| {% endblock %} | ||
| {% block call_to_action %} | ||
| <p> | ||
| {{ l10n('confirm-email-mail-html-body') }} | ||
| <center> |
There was a problem hiding this comment.
Haha yes, writing markup for mail clients is sometimes like a history lesson on the origins of HTML 😂 Or writing a website for the Netscape Navigator.
devmount
approved these changes
Sep 11, 2024
| <p style="font-weight: 700; margin: 0;"> | ||
| {{ l10n('confirm-email-mail-html-heading') }} | ||
| </p> | ||
| </div> | ||
| {% endblock %} | ||
| {% block call_to_action %} | ||
| <p> | ||
| {{ l10n('confirm-email-mail-html-body') }} | ||
| <center> |
There was a problem hiding this comment.
Haha yes, writing markup for mail clients is sometimes like a history lesson on the origins of HTML 😂 Or writing a website for the Netscape Navigator.
devmount
added a commit
that referenced
this pull request
Sep 11, 2024
* Features/579 login rework (#640) * Initial pass on login re-work: * Added generic modal component * Adjusted TextInput to delay invalid styling until first interaction * Added help message to TextInput * Adjust login screen to use generic modal over a home-view component * Fix custom validation * Array<T> -> T[] * Fix padding on homepage, fix copywrite year, and add report bug link to navbar, * Re-enable redis + use cluster mode * Fix for redis error in cluster mode * Redis debugging * Revert "Redis debugging" This reverts commit da0bb0a. * Add some performance profiling for redis * Upgrade posthog * Try a suggested param to speed up cluster booting * Try eager loading calendars for appointment.get_by_subscriber * Eager load on joined for apmt slots and attendees * Revert "Eager load on joined for apmt slots and attendees" This reverts commit 1910ab3. * Fix error with eager loading * Connect to the redis cluster at the start of the app * ...actually hook up the lifespan function * Adjust retry strategy for redis cluster * Login Re-work Pt2 (#646) * Re-work waiting list action, and string extract. * Update confirm your email...email * 🌐 Update German translation, sort lang keys --------- Co-authored-by: Andreas Müller <mail@devmount.de> --------- Co-authored-by: Mel <97147377+MelissaAutumn@users.noreply.github.com> Co-authored-by: Melissa Autumn <melissa@thunderbird.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishes off #579
...I'm sorry for the amount of l10n work needed.
Screenshots