CalDAV autodiscovery #718
Open
CalDAV autodiscovery #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Renamed ftueStep.GooglePermissions to ftueStep.CalendarProvider * Add a switch button during the FTUE calendar provider step * Add modal text * Refactor LoginView::handleFormError to be generic and now lives in utils * Allow force fetching of external connections * Add CalDAV as an external connection option * Refactor GoogleOauthProvider to be more in-line with how CalDAVProvider works * Add shortcuts for decrypt/encrypt in Python utils * Cache dns lookup for the remainder of the ttl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #446
I started off just re-enabling the old behaviour but found it didn't really work in context of the FTUE. So I've added the ability to save CalDAV principal servers as an external connection. That required a lot of additional work, whoops!
Note: This does not affect the "Add a single caldav calendar" functionality that exists on the calendars setting page. This simply treats a caldav principal server connection like we would google oauth.
Changes:
Screenshots