Disable version-branching; add Ruff checks #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanjjung
changed the title
Closed
malini
reviewed
Oct 4, 2024
| # | ||
| # - When a PR is opened against `main`, or if that PR changes: | ||
| # - Figure out if any code changes have been made | ||
| # - Require a version number change |
There was a problem hiding this comment.
I'm not sure if we want this all the time; if we start a new project and want to stay in 'dev' mode on main until we release, then it would be meaningless to increment some artificial version number. IMO, if we want to make versioned releases, we should cut new branches with that intent.
There was a problem hiding this comment.
oh, or is this just for this repo's workflow, and not part of the pulumi shared workflow code? Because then, that makes sense and you can disregard my comment.
There was a problem hiding this comment.
This workflow is designed for this project's workflow only. This concerns how this project's PRs are processed.
malini
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Two main changes here:
vX.Y.Zbranch being created. This cannot be done with GHA right now because our branch is protected.ruff checkto theruff format --checkwe were previously running. This catches more than just textual issues.Benefits
We'll have some kind of automation and robotic double-checking, even if I have to cut version branches by hand for now.
Applicable Issues
Issue #17