Resolve CF logging bucket errors #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanjjung
commented
Oct 15, 2024
| @@ -67,15 +67,6 @@ jobs: | |||
| with: | |||
| branch: v${{ steps.version.outputs.value }} | |||
|
|
|||
| # Fail on version collision. Every change to code requires an update to the version number. | |||
There was a problem hiding this comment.
Removing this check because we should not enforce a 1:1 relationship between PRs and releases.
malini
approved these changes
Oct 15, 2024
ryanjjung
commented
Oct 15, 2024
| 'id': aws.s3.get_canonical_user_id().id, | ||
| 'uri': '', | ||
| } | ||
| ], |
There was a problem hiding this comment.
AWS has disabled ACLs on S3 buckets by default. CloudFront needs this grant to work. Grants need ACLs enabled to work. Therefore, describing this grant here creates a circular dependency which cannot be resolved. For this reason, the BucketAclV2 resource is created below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves Issue #21