Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MessageList colors for better contrast #8596

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

wmontwe
Copy link
Member

@wmontwe wmontwe commented Nov 20, 2024

This removes the custom color attributes and replaces them by Material 3 colors.

In result it's already better for the light theme, while the dark theme could be still tweaked to enhance the visual distinction between read and unread emails.

@wmontwe wmontwe requested a review from cketti as a code owner November 20, 2024 14:13
@kewisch
Copy link
Member

kewisch commented Nov 20, 2024

Let's discuss this with design first before we remove the colors, good to have a final suggestion before we proceed with intermediate changes

@wmontwe
Copy link
Member Author

wmontwe commented Nov 20, 2024

I removed this attributes as they should have been removed already before. They are just blocking the view on the actual issue. And yes, this has been discussed and agreed before with design. Just other things have been more important. But anyway.

The colors needs to be adjusted to follow the last design proposal.

@wmontwe wmontwe force-pushed the fix-message-list-colors branch 5 times, most recently from 8107def to d81acaa Compare November 25, 2024 17:06
@wmontwe wmontwe force-pushed the fix-message-list-colors branch 3 times, most recently from 693262a to fad4d4c Compare January 24, 2025 13:08
@wmontwe
Copy link
Member Author

wmontwe commented Jan 24, 2025

I changed the colors but I'm waiting for design feedback on some adjustments.

@wmontwe wmontwe force-pushed the fix-message-list-colors branch 2 times, most recently from d2eb090 to 2c36f4f Compare January 24, 2025 15:24
@wmontwe wmontwe force-pushed the fix-message-list-colors branch from 2c36f4f to 160da23 Compare January 24, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants