-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial focus in message compose screen #8664
Conversation
shamim-emon
commented
Dec 11, 2024
- Deals with initial focus point on mail compose screen
- fixes Initial focus in message compose screen #7635
35c28c5
to
56471f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For future changes: I think breaking down the code changes into separate commits would help us to review your changes better. Consider applying each change individually: move Java to a new class, then convert to Kotlin, and finally refactor.
Besides that it works as expected and it seems that the corner cases still work.
Just the RecipientMvpView
doesn't need to be a member of MessageCompose
as it's only needed during onCreate
legacy/ui/legacy/src/main/java/com/fsck/k9/activity/MessageCompose.java
Outdated
Show resolved
Hide resolved
legacy/ui/legacy/src/main/java/com/fsck/k9/activity/MessageCompose.java
Outdated
Show resolved
Hide resolved
legacy/ui/legacy/src/main/java/com/fsck/k9/ui/compose/IntentDataMapper.kt
Show resolved
Hide resolved
56471f1
to
112bc32
Compare
legacy/ui/legacy/src/main/java/com/fsck/k9/activity/MessageCompose.java
Outdated
Show resolved
Hide resolved
fb0bab6
to
3560939
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!