Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial focus in message compose screen #8664

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

shamim-emon
Copy link
Contributor

Copy link
Member

@wmontwe wmontwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future changes: I think breaking down the code changes into separate commits would help us to review your changes better. Consider applying each change individually: move Java to a new class, then convert to Kotlin, and finally refactor.

Besides that it works as expected and it seems that the corner cases still work.

Just the RecipientMvpView doesn't need to be a member of MessageCompose as it's only needed during onCreate

@shamim-emon shamim-emon requested a review from kewisch as a code owner January 31, 2025 14:38
@shamim-emon shamim-emon requested a review from wmontwe January 31, 2025 14:39
Copy link
Member

@wmontwe wmontwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@wmontwe wmontwe merged commit d214077 into thunderbird:main Jan 31, 2025
3 checks passed
@shamim-emon shamim-emon deleted the fix-issue-7635 branch February 1, 2025 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initial focus in message compose screen
2 participants