Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show copied to clipboard snackbar #242

Merged

Conversation

Prakhar-Agarwal-byte
Copy link
Contributor

Fixes #241, #201

Screenshot:
WhatsApp Image 2023-03-01 at 3 06 07 AM

@fivetran-tangyetong
Copy link
Collaborator

Hi Prakhar thanks for opening up the PR for this issue!
With regards to issue #201 , does this PR also fix the unwanted toast being fired in other API versions? Just wanted to check since we are not sure why the toast was being fired in the first place.

@Prakhar-Agarwal-byte
Copy link
Contributor Author

I tested it on API 30 didn't get the toast anymore.

Copy link
Owner

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 875f81c.

@thunderbiscuit
Copy link
Owner

@Prakhar-Agarwal-byte please rebase to pick up the latest changes on master and I'll merge this one next.

@Prakhar-Agarwal-byte
Copy link
Contributor Author

Rebased on master

@thunderbiscuit thunderbiscuit merged commit 688b222 into thunderbiscuit:master Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a toast on copying Padawan address
3 participants