Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add CONTRIBUTING.md file #261

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

ConnectBhawna
Copy link
Contributor

I have added a Code of conduct along with Contributing guidelines to the project. In my Contributing guideline, I have not provided a link for the IHR Code of conduct, in case this gets merged I would add the link else the link would redirect to my repo. Let me know what you think about the rules and approach I have provided. @thunderbiscuit sir incase you need some changes let me know I would make and send the PR again.

Solved issue #245

@thunderbiscuit thunderbiscuit self-requested a review March 7, 2023 18:38
@thunderbiscuit thunderbiscuit added the documentation Improvements or additions to documentation label Mar 7, 2023
Copy link
Owner

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! As per #244, let's remove the code of conduct file from this PR.

@thunderbiscuit
Copy link
Owner

thunderbiscuit commented Mar 9, 2023

Thank you! Now you have 2 commits that simply need to be squashed and this one is ready to go. Are you ok with squashing and force-pushing? You might need to look up some documentation or youtube video if you have not done it before. Let me know if you want pointers.

@ConnectBhawna
Copy link
Contributor Author

Okk sir, I will do this by today :)

@thunderbiscuit
Copy link
Owner

@ConnectBhawna let me know if you're still interested in getting this merged. I think it's almost there...

@ConnectBhawna
Copy link
Contributor Author

Yes sir, Let me know what i need to change now

@thunderbiscuit thunderbiscuit self-requested a review March 22, 2023 13:04
Copy link
Owner

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this was actually already squashed! Sorry. Ready to go.

@thunderbiscuit thunderbiscuit merged commit 9734d61 into thunderbiscuit:master Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants