Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for glibc 2.12 #50

Merged
merged 1 commit into from
Jan 24, 2022
Merged

feat: support for glibc 2.12 #50

merged 1 commit into from
Jan 24, 2022

Conversation

yisibl
Copy link
Member

@yisibl yisibl commented Jan 21, 2022

Support for CentOS 7 (glibc 2.17) and CentOS 6 (glibc 2.12).

This PR is cross-compiled with zig, passing the --zig --zig-abi-suffix 2.12 argument causes it to compile a statically linked binary.

On systems with glibc < 2.18, the error message will not appear:

Error: /lib64/libc.so.6: version `GLIBC_2.18' not found

@yisibl yisibl requested a review from Brooooooklyn January 21, 2022 09:11
@yisibl yisibl force-pushed the add-glibc-2.17 branch 3 times, most recently from f7392fb to 5565285 Compare January 21, 2022 10:05
@Brooooooklyn
Copy link
Collaborator

体积变大感觉是 rust toolchain 升级导致的问题。另外,我们可以 target 到 2.12(与兼容到 2.17 没有本质区别), 这样可以兼容到 Centos:6

@yisibl yisibl force-pushed the add-glibc-2.17 branch 3 times, most recently from 1b07dba to 59d8209 Compare January 22, 2022 06:12
@yisibl yisibl changed the title feat: support for glibc 2.17 feat: support for glibc 2.12 Jan 22, 2022
.github/workflows/CI.yaml Show resolved Hide resolved
.github/workflows/CI.yaml Show resolved Hide resolved
@yisibl
Copy link
Member Author

yisibl commented Jan 22, 2022

另外,我们可以 target 到 2.12(与兼容到 2.17 没有本质区别), 这样可以兼容到 Centos:6

都改成 2.12 了

@yisibl yisibl merged commit 93513c6 into main Jan 24, 2022
@yisibl yisibl deleted the add-glibc-2.17 branch January 24, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants