Adds quest input validation

thxprotocol · Aug 8, 2024 · 9281c67 · 9281c67
1 parent cad1887
commit 9281c67
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/apps/api/src/app/controllers/pools/quests/variant/patch.controller.ts b/apps/api/src/app/controllers/pools/quests/variant/patch.controller.ts
@@ -10,10 +10,10 @@ const controller = async (req: Request, res: Response) => {
     const variant = req.params.variant as unknown as QuestVariant;
     const questId = req.params.questId as string;
 
-    let quest = await QuestService.findById(variant, questId);
-    quest = await QuestService.update(quest, req.body, req.file);
+    const quest = await QuestService.findById(variant, questId);
+    const result = await QuestService.update(quest, req.body, req.file);
 
-    res.json(quest);
+    res.json(result);
 };
 
 export { controller, validation };
diff --git a/apps/api/src/app/models/Quest.ts b/apps/api/src/app/models/Quest.ts
@@ -6,7 +6,7 @@ export const questSchema = {
     description: String,
     image: String,
     index: Number,
-    expiryDate: Date,
+    expiryDate: { type: Date, default: '', nullable: false },
     infoLinks: [{ label: String, url: String }],
     locks: { type: [{ questId: String, variant: Number }], default: [] },
     isPublished: { type: Boolean, default: false },

diff --git a/apps/api/src/app/util/validation.ts b/apps/api/src/app/util/validation.ts
@@ -21,6 +21,14 @@ export const defaults = {
             .optional()
             .isBoolean()
             .customSanitizer((value) => JSON.parse(value)),
+        body('isReviewEnabled')
+            .optional()
+            .isBoolean()
+            .customSanitizer((value) => JSON.parse(value)),
+        body('isIPLimitEnabled')
+            .optional()
+            .isBoolean()
+            .customSanitizer((value) => JSON.parse(value)),
         check('file')
             .optional()
             .custom((value, { req }) => {