Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emitDecoratorMetadata Documentation for issue 288 #345

Merged
merged 3 commits into from
Mar 12, 2020
Merged

emitDecoratorMetadata Documentation for issue 288 #345

merged 3 commits into from
Mar 12, 2020

Conversation

mousedownmike
Copy link
Contributor

Summary

I've added documentation to the Troubleshooting section to provide some guidance on the use of the emitDecoratorMetadata compiler option for Angular 8 users as described in issue #288

Checklist

  • [X ] I added the documentation in README.md

@wtho
Copy link
Collaborator

wtho commented Feb 21, 2020

Nice! Thank you for contributing!

Just one question:

For Angular 8 users, ...

Do you know if this also applies for Angular 9 users?

…uired with Angular 9 (i.e. Angular 8 and higher)
@mousedownmike
Copy link
Contributor Author

@wtho I just confirmed that this change is required with Angular 9 so I've revised the text to reflect that it is for "Angular 8 and higher".

@wtho wtho merged commit 612be29 into thymikee:master Mar 12, 2020
@wtho
Copy link
Collaborator

wtho commented Mar 12, 2020

Thanks again for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants