Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: update the list of auto-assigned reviewers for pingcap/dm #314

Merged
merged 1 commit into from
May 17, 2021

Conversation

lance6716
Copy link
Contributor

In ti-community-blunderbuss, the config of pingcap/dm uses include_reviewers instead of exclude_reviewers.

part of #311

@ti-chi-bot
Copy link
Member

Welcome @lance6716!

It looks like this is your first PR to ti-community-infra/configs 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to ti-community-infra/configs. 😃

@ti-chi-bot ti-chi-bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels May 17, 2021
@ti-chi-bot
Copy link
Member

Hi @lance6716. Thanks for your PR.

I'm waiting for a ti-community-infra member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 17, 2021
Copy link
Contributor

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels May 17, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hi-rustin

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 17, 2021
@Rustin170506
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f6d5ca0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 17, 2021
@lance6716
Copy link
Contributor Author

lance6716 commented May 17, 2021

cc @glorv @lichunzhu

@Rustin170506
Copy link
Contributor

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 17, 2021
@Rustin170506 Rustin170506 added sig/community-infra Indicates that the Issue or PR belongs to the community-infra SIG. sig/migrate Indicates that the Issue or PR belongs to the migrate SIG. labels May 17, 2021
@Rustin170506
Copy link
Contributor

cc @glorv @lichunzhu

If you think this change OK. Feel free to /unhold.

@glorv
Copy link

glorv commented May 17, 2021

/lgtm

@glorv
Copy link

glorv commented May 17, 2021

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 17, 2021
@ti-chi-bot ti-chi-bot merged commit 597b2ec into ti-community-infra:main May 17, 2021
@ti-chi-bot
Copy link
Member

@lance6716: Updated the external-plugins-config configmap in namespace prow at cluster default using the following files:

  • key external_plugins_config.yaml using file prow/config/external_plugins_config.yaml

In response to this:

In ti-community-blunderbuss, the config of pingcap/dm uses include_reviewers instead of exclude_reviewers.

part of #311

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. ok-to-test Indicates a PR is ready to be tested. sig/community-infra Indicates that the Issue or PR belongs to the community-infra SIG. sig/migrate Indicates that the Issue or PR belongs to the migrate SIG. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants