Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

errors: replace errors.Wrap() with errors.Is() #30

Merged
merged 5 commits into from
Dec 20, 2022
Merged

errors: replace errors.Wrap() with errors.Is() #30

merged 5 commits into from
Dec 20, 2022

Conversation

ti-mo
Copy link
Owner

@ti-mo ti-mo commented Dec 19, 2022

No description provided.

@coveralls
Copy link

coveralls commented Dec 19, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3739760027

  • 156 of 168 (92.86%) changed or added relevant lines in 8 files are covered.
  • 15 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-1.6%) to 91.844%
Changes Missing Coverage Covered Lines Changed/Added Lines %
tuple.go 26 27 96.3%
attribute_types.go 44 46 95.65%
flow.go 45 47 95.74%
conn.go 2 5 40.0%
expect.go 31 35 88.57%
Files with Coverage Reduction New Missed Lines %
tuple.go 1 98.72%
event.go 2 96.36%
flow.go 2 97.66%
conn.go 4 78.42%
stats.go 6 93.26%
Totals Coverage Status
Change from base Build 3730662547: -1.6%
Covered Lines: 1340
Relevant Lines: 1459
💛 - Coveralls

ti-mo added 4 commits December 20, 2022 11:38
@ti-mo
Conn: exit worker's receive loop if underlying fd was closed
6db54e5 
This was causing some CI failures due to errChan no longer being read from in
TestConnListen, and EBADF wrongly being sent to errChan.

Workers now correctly exit when attempting to read from a closed Conn.
@ti-mo
Upgrade testify to 1.8.1
4276fbc
@ti-mo
errors: replace errors.Wrap() with errors.Is()
2bf6631
@ti-mo
Add .golangci.yaml
9c4b48a
@ti-mo ti-mo merged commit eddca92 into master Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ti-mo @coveralls