Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] check_compliance.py needs support for Bridle's downstream modules folder #159

Closed
rexut opened this issue Nov 20, 2023 · 1 comment
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@rexut
Copy link
Member

rexut commented Nov 20, 2023

Describe the bug

Traceback (most recent call last):
  File ".../workspace/zephyr/scripts/kconfig/kconfiglib.py", line 2190, in _enter_file
    self._readline = self._open(filename, "r").readline
  File ".../workspace/zephyr/scripts/kconfig/kconfiglib.py", line 3959, in _open
    open(filename, mode, encoding=self._encoding)
IsADirectoryError: [Errno 21] Is a directory: '.../workspace/zephyr/'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "./scripts/ci/check_compliance.py", line 1267, in main
    n_fails = _main(args)
  File "./scripts/ci/check_compliance.py", line 1202, in _main
    test.run()
  File "./scripts/ci/check_compliance.py", line 682, in run
    super().run(full=False)
  File "./scripts/ci/check_compliance.py", line 270, in run
    kconf = self.parse_kconfig()
  File "./scripts/ci/check_compliance.py", line 384, in parse_kconfig
    return kconfiglib.Kconfig()
  File ".../workspace/zephyr/scripts/kconfig/kconfiglib.py", line 947, in __init__
    self._init(filename, warn, warn_to_stderr, encoding)
  File ".../workspace/zephyr/scripts/kconfig/kconfiglib.py", line 1085, in _init
    self._parse_block(None, self.top_node, self.top_node).next = None
  File ".../workspace/zephyr/scripts/kconfig/kconfiglib.py", line 3001, in _parse_block
    prev = self._parse_block(None, parent, prev)
  File ".../workspace/zephyr/scripts/kconfig/kconfiglib.py", line 3040, in _parse_block
    self._parse_block(_T_ENDMENU, node, node)
  File ".../workspace/zephyr/scripts/kconfig/kconfiglib.py", line 3001, in _parse_block
    prev = self._parse_block(None, parent, prev)
  File ".../workspace/zephyr/scripts/kconfig/kconfiglib.py", line 3001, in _parse_block
    prev = self._parse_block(None, parent, prev)
  File ".../workspace/zephyr/scripts/kconfig/kconfiglib.py", line 3040, in _parse_block
    self._parse_block(_T_ENDMENU, node, node)
  File ".../workspace/zephyr/scripts/kconfig/kconfiglib.py", line 3000, in _parse_block
    self._enter_file(filename)
  File ".../workspace/zephyr/scripts/kconfig/kconfiglib.py", line 2193, in _enter_file
    raise _KconfigIOError(
kconfiglib._KconfigIOError: /tmp/Kconfig.modules:206: Could not open '.../workspace/zephyr/' (in 'osource "$(ZEPHYR_UBXLIB_KCONFIG)"') (EISDIR: Is a directory)

To Reproduce
Steps to reproduce the behavior: See https://github.com/tiacsys/bridle/actions/runs/6926377539/job/18838445069?pr=158

Expected behavior
./scripts/ci/check_compliance.py --annotate -m KconfigBasic -c origin/v3.6-branch.. works w/o side effects also for downstrem modules folder.

Impact
No showstopper for the time being, but should be fixed until next Bridle release.

Logs and console output

See: https://github.com/tiacsys/bridle/actions/runs/6926377539/job/18838445069?pr=158

Screenshots

Non.

Development Environment (please complete the following information):

  • OS: Linux
  • Toolchain: Zephyr SDK v0.16.5
  • Commit 59aa31a6b0742175c5fa1293ad2ad792b45dd9da, Version 3.6.0-rc1, Branch v3.6-next

Additional context

Non.

@rexut rexut added the bug Something isn't working label Nov 20, 2023
@rexut rexut self-assigned this Nov 20, 2023
rexut added a commit that referenced this issue Nov 20, 2023
See bug issue #159. That have to revert as soon as possible.

Signed-off-by: Stephan Linz <linz@li-pro.net>
@rexut rexut added this to the v3.5.99 milestone Nov 20, 2023
rexut added a commit that referenced this issue Nov 20, 2023
See bug issue #159. That have to revert as soon as possible.

Signed-off-by: Stephan Linz <linz@li-pro.net>
Copy link

This issue has been marked as stale because it has been open (more than) 90 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 30 days. Note, that you can always re-open a closed issue at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant