Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] build all Bridle samples test runs into devicetree error #272

Closed
3 tasks done
rexut opened this issue Nov 10, 2024 · 0 comments · Fixed by #273
Closed
3 tasks done

[BUG] build all Bridle samples test runs into devicetree error #272

rexut opened this issue Nov 10, 2024 · 0 comments · Fixed by #273
Assignees
Labels
bug Something isn't working
Milestone

Comments

@rexut
Copy link
Member

rexut commented Nov 10, 2024

Describe the bug
Zephyr upstream no longer supports the inflexible Kconfig object SDMMC_VOLUME_NAME and requires a proper name setup on Device tree level by the new property disk-name.

To Reproduce
Steps to reproduce the behavior:

  1. proper Bridle workspace setup from main branch
  2. west twister \
           --jobs 4 \
           --verbose \
           --inline-logs \
           --integration \
           --testsuite-root bridle/samples/helloshell
    
  3. See error below…

Expected behavior
Test suite runs properly without any error.

Impact
Showstopper, because the CI pipeline will fail.

Logs and console output

devicetree error: 'disk-name' is marked as required in 'properties:'
  in .../zephyr/dts/bindings/sd/zephyr,sdmmc-disk.yaml, but does not appear
  in <Node /soc/spi@4003c000/sdhc@0/mmc in '.../zephyr/misc/empty_file.c'>

Screenshots
None.

Development Environment (please complete the following information):

  • OS: Linux
  • Toolchain: West v1.3.0, CMake v3.28.1, Sphinx v8.1.3, Doxygen v1.9.8
  • Branch: main, Zephyr v4.0.0-rc2 (upstream main)

Additional context
Add the missing property in Bridle's Devicetree includes.

Procedure

See: zephyrproject-rtos/zephyr#80709 – SDMMC and MMC subsystem disk drivers rework

Since zephyrproject-rtos/zephyr@a1dc0b8 Zephyr upstream has removed CONFIG_SDMMC_VOLUME_NAME, and set the disk name based on the disk-name property. This aligns with other disk drivers, and allows for multiple instances of the sdmmc_subsys disk driver to be registered.

Bridle uses the sdmmc_subsys disk driver in following boards and shields:

@rexut rexut added the bug Something isn't working label Nov 10, 2024
@rexut rexut self-assigned this Nov 10, 2024
@rexut rexut modified the milestones: v3.7.99, v4.0.0 Nov 10, 2024
rexut added a commit that referenced this issue Nov 10, 2024
Add statement about the copy-and-onw of Sphinx extension warnings_filter.
Add GitHub issues #270, #271 and #272.

Signed-off-by: Stephan Linz <linz@li-pro.net>
rexut added a commit that referenced this issue Nov 10, 2024
Add statement about the copy-and-onw of Sphinx extension warnings_filter.
Add GitHub issues #270, #271 and #272.

Signed-off-by: Stephan Linz <linz@li-pro.net>
rexut added a commit that referenced this issue Nov 14, 2024
Add statement about the copy-and-onw of Sphinx extension warnings_filter.
Add GitHub issues #270, #271 and #272.

Signed-off-by: Stephan Linz <linz@li-pro.net>
rexut added a commit that referenced this issue Nov 14, 2024
Add statement about the copy-and-own of Sphinx extension warnings_filter.
Add GitHub issues #270, #271 and #272.

Signed-off-by: Stephan Linz <linz@li-pro.net>
rexut added a commit that referenced this issue Nov 15, 2024
Add statement about:

  * the CI workflow changes
  * the standalone 'stm32f777xx' SoC support by Bridle
  * the DTS binding and Kconfig changes for the two I2C-based
    GPIO expander 'PCA9554' and 'PCA9555'
  * the copy-and-own of Sphinx extension 'warnings_filter'
  * the changes on documentation level: Sphinx v8.1, Sphinx
    copy button, inter-Sphinx links with valid official syntax
    and update output messages

Add GitHub issues #270, #271 and #272.

Signed-off-by: Stephan Linz <linz@li-pro.net>
rexut added a commit that referenced this issue Nov 15, 2024
Add statement about:

  * the CI workflow changes
  * the standalone 'stm32f777xx' SoC support by Bridle
  * the DTS binding and Kconfig changes for the two I2C-based
    GPIO expander 'PCA9554' and 'PCA9555'
  * the copy-and-own of Sphinx extension 'warnings_filter'
  * the changes on documentation level: Sphinx v8.1, Sphinx
    copy button, inter-Sphinx links with valid official syntax
    and update output messages

Add GitHub issues #270, #271 and #272.

Signed-off-by: Stephan Linz <linz@li-pro.net>
rexut added a commit that referenced this issue Nov 18, 2024
Add statement about:

  * the CI workflow changes
  * the standalone 'stm32f777xx' SoC support by Bridle
  * the DTS binding and Kconfig changes for the two I2C-based
    GPIO expander 'PCA9554' and 'PCA9555'
  * the copy-and-own of Sphinx extension 'warnings_filter'
  * the changes on documentation level: Sphinx v8.1, Sphinx
    copy button, inter-Sphinx links with valid official syntax
    and update output messages

Add GitHub issues #270, #271 and #272.

Signed-off-by: Stephan Linz <linz@li-pro.net>
@rexut rexut modified the milestones: v3.7.99, v4.0.0 Nov 18, 2024
rexut added a commit that referenced this issue Nov 18, 2024
Add statement about:

  * the CI workflow changes
  * the standalone 'stm32f777xx' SoC support by Bridle
  * the DTS binding and Kconfig changes for the two I2C-based
    GPIO expander 'PCA9554' and 'PCA9555'
  * the copy-and-own of Sphinx extension 'warnings_filter'
  * the changes on documentation level: Sphinx v8.1, Sphinx
    copy button, inter-Sphinx links with valid official syntax
    and update output messages

Add GitHub issues #270, #271, #272 and #274.

Signed-off-by: Stephan Linz <linz@li-pro.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant