Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request(feature:color-picker) Support different color formats than HEX #140

Closed
motabass opened this issue Jul 23, 2020 · 3 comments · Fixed by #149
Closed

request(feature:color-picker) Support different color formats than HEX #140

motabass opened this issue Jul 23, 2020 · 3 comments · Fixed by #149
Assignees
Labels
Milestone

Comments

@motabass
Copy link
Contributor

motabass commented Jul 23, 2020

There should be the possibility to configure the format of the color-code input currently only supporting hex.

Following formats could be support depending on if alpha selector is enabled:

Non alpha:

  • hex: #ffffff
  • rgb: rgb(255,255,255)
  • hsl: hsl(360, 100%, 100%)
  • hsv: hsv(360, 100%, 100%)

With alpha:

  • hexa: #ffffffff
  • rgba: rgba(255,255,255,1)
  • hsla: hsla(360, 100%, 100%, 1)
  • hsva: hsva(360, 100%, 100%, 1)

for input by user also hex codes in the form of #fff and #ffff could be supported. The Input should be parsed and applied on blur or ⏎

@motabass motabass changed the title feature(color-picker) add different modes for current hex input frequest(feature:color-picker) add different modes for current hex input Jul 23, 2020
@motabass motabass changed the title frequest(feature:color-picker) add different modes for current hex input frequest(feature:color-picker) Support different color formats than HEX Jul 24, 2020
@motabass
Copy link
Contributor Author

prepared by #142

@tiaguinho tiaguinho added this to the v7.2.0 milestone Jul 27, 2020
@tiaguinho tiaguinho linked a pull request Jul 27, 2020 that will close this issue
@motabass
Copy link
Contributor Author

in #142 there is only support for rgba and hex6 as component-input-strings not inside the hex input of the picker. I#d like to tackle this in another PR.

@motabass motabass changed the title frequest(feature:color-picker) Support different color formats than HEX request(feature:color-picker) Support different color formats than HEX Jul 29, 2020
@tiaguinho tiaguinho removed a link to a pull request Jul 29, 2020
@motabass
Copy link
Contributor Author

motabass commented Aug 3, 2020

Different color string formats for inputs and outputs are supported with #149.

The format on the ui still is hex(a) and rgb(a), where support for hex8 (#FFFFFFFF) was newly added. hex3 (#fff) and hex4 (#ffff) are also still not supported on the Picker-UI yet. This will be another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants