-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(color-picker): Configurable color string format (HEX,RGB,HSL,HSV) #149
Conversation
@tiaguinho BTW: what do you think about updating the dependencies? |
@motabass I think it's a good idea. |
Sure. |
@motabass can you do a rebase with the master branch? |
done |
@motabass there is a little bug. |
I took a look at it. I think that happens because of the service holding the _selectedColor. All collection components get this value OnInit and when updated.
|
The Problem you described should now be fixed. I moved the selectedColor stuff into another service which is provided by the Component. So every Color-Picker has its own Service only for that Thanks for the review! |
Thanks for fixing the bug. |
done |
…use of blocked cursor
I also finally added some ...and i changed the version shown in demo to 7.2.0 |
…ias for tinycolor.Instance
Implementing #140
Format is only for Output of the color-picker and internal string representations.
As Inputs (selectedColor, addColor, USED_COLORS) ALL formats supported by tinycolor are supported (https://github.com/thebespokepixel/es-tinycolor/blob/master/readme.md). They are then normalized to the selected COLOR_STRING_FORMAT internaly.