-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(color-picker, time-picker): round corners, @HostListeners, openOnFocus for mccColorPickerOrigin, examples, time picker fixes #158
Conversation
…cColorPickerOrigin, examples
This also removes open Sans font and uses Roboto instead, aligns border-radius and elevation with what @angular/material uses for the datepicker (z4, and border-radius: 4px) furthermore both color-picker and time-picker use the same button layout and default "Confirm" button text. |
…levations,'' as EMPTY_COLOR
11d2f0e
to
1843530
Compare
@motabass this is ready for review? |
@tiaguinho yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@motabass In some methods, you have removed the documentation of params. There is some reason for that?
@tiaguinho i re-added the animation and the comment. I removed the @param comments because they seemed redundant to me when strongly typing it with TS. The thing with the animation is, that one does not see it too much, because when hour is selected the view changes to minutes immediatly after the click. The same is true for the minutes when using the picker with hidden buttons. I was trying to add some delay, but i'm not sure if its a good idea really, also the test made problems then....what do you think? Furthermore the animation is not going clockwise all the time and the selection-circle around the number is not animated which leads to looking strange while animating: |
Makes sense @motabass. Please let me know when I can do the review again. Thank you! |
@tiaguinho I'm ready! |
implements #148