parser: create integer type field with specified length should have w…

…arings (pingcap#939) * . Signed-off-by: AilinKid <314806019@qq.com> * . Signed-off-by: AilinKid <314806019@qq.com> * . Signed-off-by: AilinKid <314806019@qq.com> * . Signed-off-by: AilinKid <314806019@qq.com> * . Signed-off-by: AilinKid <314806019@qq.com>
tiancaiamao · Jul 24, 2020 · 2dedd43 · 2dedd43
1 parent 44bfb50
commit 2dedd43
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/parser.go b/parser.go
diff --git a/parser.y b/parser.y
@@ -9791,6 +9791,10 @@ NumericType:
 		// TODO: check flen 0
 		x := types.NewFieldType($1.(byte))
 		x.Flen = $2.(int)
+		if $2.(int) != types.UnspecifiedLength {
+			yylex.AppendError(yylex.Errorf("Integer display width is deprecated and will be removed in a future release."))
+			parser.lastErrorAsWarn()
+		}
 		for _, o := range $3.([]*ast.TypeOpt) {
 			if o.IsUnsigned {
 				x.Flag |= mysql.UnsignedFlag

diff --git a/yy_parser.go b/yy_parser.go
@@ -49,6 +49,10 @@ var (
 	ErrUnknownAlterAlgorithm = terror.ClassParser.New(mysql.ErrUnknownAlterAlgorithm, mysql.MySQLErrName[mysql.ErrUnknownAlterAlgorithm])
 	// ErrWrongValue returns for wrong value
 	ErrWrongValue = terror.ClassParser.New(mysql.ErrWrongValue, mysql.MySQLErrName[mysql.ErrWrongValue])
+	// ErrWarnDeprecatedSyntaxNoReplacement return when the syntax was deprecated and there is no replacement.
+	ErrWarnDeprecatedSyntaxNoReplacement = terror.ClassParser.New(mysql.ErrWarnDeprecatedSyntaxNoReplacement, mysql.MySQLErrName[mysql.ErrWarnDeprecatedSyntaxNoReplacement])
+	// ErrWarnDeprecatedIntegerDisplayWidth share the same code 1681, and it will be returned when length is specified in integer.
+	ErrWarnDeprecatedIntegerDisplayWidth = terror.ClassParser.New(mysql.ErrWarnDeprecatedSyntaxNoReplacement, "Integer display width is deprecated and will be removed in a future release.")
 	// SpecFieldPattern special result field pattern
 	SpecFieldPattern = regexp.MustCompile(`(\/\*!(M?[0-9]{5,6})?|\*\/)`)
 	specCodeStart    = regexp.MustCompile(`^\/\*!(M?[0-9]{5,6})?[ \t]*`)