Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix readme #6

Merged
merged 3 commits into from
Jun 8, 2020
Merged

Fix readme #6

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b56b6f9
avoid using ' in the msg
svlandeg Jun 8, 2020
02e6749
further removing '
svlandeg Jun 8, 2020
615204f
further fix
svlandeg Jun 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ Imagine this JSON config:
{
"answered": {
"delay": "P3DT12H30M5S",
"message": "It seems the issue was answered, I'll close this now."
"message": "It seems the issue was answered, closing this now."
},
"validated": {
"delay": 300,
Expand All @@ -90,7 +90,7 @@ In this case, if:
...the GitHub action would close the issue with a message of:

```markdown
It seems the issue was answered, I'll close this now.
It seems the issue was answered, closing this now.
```

But if there was a new comment created _after_ the label was added, by default, it would remove the label.
Expand Down Expand Up @@ -216,7 +216,7 @@ jobs:
{
"answered": {
"delay": "P3DT12H30M5S",
"message": "It seems the issue was answered, I'll close this now."
"message": "It seems the issue was answered, closing this now."
},
"validated": {
"delay": 300,
Expand Down Expand Up @@ -283,7 +283,7 @@ jobs:
"dmontagu"
],
"delay": "P3DT12H30M5S",
"message": "It seems the issue was answered, I'll close this now.",
"message": "It seems the issue was answered, closing this now.",
"remove_label": false
},
"validated": {
Expand Down Expand Up @@ -346,7 +346,7 @@ Moreover, if I closed the issue prematurely, there's a smaller chance that I (or

But then, if I leave the issue open after giving an answer, in many cases, the issue will keep open until I come back to close it, after many days.

Then, after that time (10 days, 30 days) and after seeing that there are no new comments, I write "I assume the problem is solved, I'll close this issue now".
Then, after that time (10 days, 30 days) and after seeing that there are no new comments, I write "I assume the problem is solved, closing this issue now".

But that requires me going through all the open issues again, one by one, check where I (or someone else) have already answered, typing that message, etc.

Expand Down